Only concat concatable scripts and styles #83
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Behavior
Only scripts and assets that are concatable should be allowed to be overridden by the
css_do_concat
andjs_do_concat
filters.Actual Behavior
Both filters don't take into consideration whether a script/asset is concatable. One example is:
https://github.com/Automattic/nginx-http-concat/blob/master/jsconcat.php#L100-L103
Where you could attempt to concat an external script.
Steps to Reproduce
The simplest way to reproduce is adding: